Dev compiler merge #27213
Closed
Dev compiler merge #27213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded except for js_array_test.dart and js_dart_to_string_test.dart which have to be stripped out for now due to failures. BUG= [email protected] Review URL: https://codereview.chromium.org/1930043002 .
Dart `%` is modulo, JS `%` is remainder, so call the runtime version. Use dart2js interpretation of bit operations and shifts which always produce a 32-bit unsigned result. Optimization of the bit operations to follow. BUG= dart-archive/dev_compiler#518 [email protected] Review URL: https://codereview.chromium.org/1924413002 .
- JavaScript shifts can be used for operands in certain ranges. - Coercion from signed-32 to unsigned-32 can be omitted if - it is a no-op - the context performs the coercion - the context is insensitive to the most significant bit [email protected] Review URL: https://codereview.chromium.org/1920293005 .
Most operations don't check, that will happen as more code is updated to a more recent sdk. BUG= [email protected] Review URL: https://codereview.chromium.org/1939093003 .
If I rebuild the SDK, I see a cast from List to List<E> on the next line without this. With the change, we just infer List<E> in the first place. [email protected] Review URL: https://codereview.chromium.org/1945793002 .
Undoing this. Paul fixed this in 1.17. We'll need to run with 1.17 builds going forward, but we need that for other reasons. Fixes #537 [email protected] Review URL: https://codereview.chromium.org/1936693002 .
This is a temporary solution. When we have an implementation of const maps, we should switch to that. BUG= [email protected] Review URL: https://codereview.chromium.org/1946663002 .
- Instead of using the raw runtime type that DDC uses for its type checks, use a WrappedType that correctly implements Type's interface. - Compile class literals to wrap the type in a WrappedType. - Make Object.runtimeType() do the same thing. Fixes #488. Fixes #511. [email protected] Review URL: https://codereview.chromium.org/1944483002 .
top-level fields, getters, setters were all broken [email protected] Review URL: https://codereview.chromium.org/1949733002 .
Also - allow failing tests to be run and checked for failure BUG= [email protected] Review URL: https://codereview.chromium.org/1946853002 .
This is for testing purposes and hence in tool. Gives a dart2js-ish API to invoke DDC, but stuffs everything in one module. Closed https://codereview.chromium.org/1900813002/ in favor of this. [email protected] Review URL: https://codereview.chromium.org/1951433002 .
Also, fix the language test for this to actually do something useful. I accidentally removed the definition of testType() in the last patch, so the test did nothing. :( Fixes #547. [email protected] Review URL: https://codereview.chromium.org/1945643005 .
Also - update some error helpers functions in the js runtime. - add 'int' to stringFromCharCode to avoid dcalls. [email protected] Review URL: https://codereview.chromium.org/1947723002 .
99 have compile errors 265 generate code 94 fail We will triage after updating the sdk. [email protected] Review URL: https://codereview.chromium.org/1945153002 .
the DDC runtime returns null when a difference from the spec mode result is possible. Fixes dart-archive/dev_compiler#524 . BUG= [email protected], [email protected] Review URL: https://codereview.chromium.org/1945113003 .
'compile' command is obsolete
We're getting bot failures due to analyzer deprecation messages. [email protected], [email protected] Review URL: https://codereview.chromium.org/2258873002 .
About 50 tests pass right now. A bunch more fail. See #199 [email protected] Review URL: https://codereview.chromium.org/2256393002 .
Doh! [email protected] Review URL: https://codereview.chromium.org/2265533002 .
the .dart script is left over from when we couldn't build SDK via normal compile path [email protected] Review URL: https://codereview.chromium.org/2265303002 .
This reverts commit 4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3. apparently we use it for code coverage. go figure. Review URL: https://codereview.chromium.org/2261183004 .
…ded to dart2js and dartium. BUG= [email protected] Review URL: https://codereview.chromium.org/2269963005 .
I also renamed "outPath" so this bug is less likely to happen in the future :) [email protected] Review URL: https://codereview.chromium.org/2279833002 .
- increase timeout so we load all tests - mark a few more failures - skip unittest tests until we re-triage them Review URL: https://codereview.chromium.org/2279053002 .
Updating to the latest analyzer. [email protected] Review URL: https://codereview.chromium.org/2289263004 .
TBR'ing to get travis green [email protected] Review URL: https://codereview.chromium.org/2294333002 .
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
yes @googlebot we're okay, this is merging in another repository also in the Dart-lang project that has the exact same CLA and license. :) |
|
This merge (I'm guessing) has accidentally closed some issues (e.g., #270 and #221) because the dev-compiler commit messages said that it "fixes" that issue (presumably the number is for the dev-compiler repository). Please check if there are more issues "fixed" by this commit. This also means that all your issue links in commit messages are now incorrect. You may consider rolling the merge back and find a way to roll it back in with either correct links to the old repository, or move the issues to the sdk repo and update the links. |
|
oh, sneaky github. Thanks so much @lrhn for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges dev_compiler from https://github.com/dart-lang/dev_compiler into pkg/dev_compiler. Build is adjusted to use the new location.