Deprecate extension methods returning Point

[parlough]

Point really shouldn't exist in its current form so we shouldn't encourage or enable its use.

If anyone still thinks these extensions are helpful, maybe we could return a record instead.

[kevmoo]

Ooo....record could be nice.

[kevmoo]

@srujzs @devoncarew – thoughts here?

[kevmoo]

Why don't we like Point, @parlough ?

[srujzs]

I am curious why we want to discourage Point as well - is dart:math planning on deprecating it?

[parlough]

A Point on a screen does not really belong in a math library, nor does Rectangle. Beyond that, Point declares operators that don't make sense for a point, conflating it with a vector (which would make more sense). The * operator on Point<int> can also have a runtime error 😢 when provided with a double.

Beyond those potential sources of confusion, I guess it being generic can introduce performance issues (dart-lang/sdk#53912).

is dart:math planning on deprecating it?

I believe there's been a variety of other discussions around this over the years, but since dart:html used it, it was likely hard to deprecate and remove. With this web migration, I think it's time to revisit that. Whether we do/can or not, it seems better avoid new uses where possible. Anyone using Point here likely just needs the x and y, and direct access or a record can provide that.

Edit: Formalized this into an SDK issue: dart-lang/sdk#54852

[srujzs]

Thanks for the reasoning! I'm okay with avoiding new uses for now. We can always re-add (or users can in their own libraries) if we think this is safe.

[kevmoo]

Or do we just move to the Record and include it in the breaking change?!?!

Might be good to do now!

[srujzs]

Either way works. I presume there's very low usage of this, and since we're releasing a breaking change version, might as well remove it instead of deprecating.

[kevmoo]

@srujzs – or just replace the return type!

[parlough]

I'd really suggest we deprecate or remove these for this release. Then revisit extensions returning records in the future. For example MouseEvent has a bunch of other somethingX and somethingY values that we don't expose through extensions like this. Seems better to have a consistent experience until its decided to expose these extensions consistently.

It's much easier to add extensions back :)