Skip to content

Deprecate extension methods returning Point #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
- Deprecate the top-level `createElementTag`, `createCanvasElement`,
`createIFrameElement`, and `querySelector` functions.
Instead, use the standard creation and query methods on `document`.
- Deprecate the `client` extension methods on `MouseEvent` and `Touch`.
Instead, directly use the `clientX` and `clientY` properties.

## 0.4.2

Expand Down
12 changes: 12 additions & 0 deletions lib/src/helpers/extensions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,22 @@ extension NodeGlue on Node {
}

extension EventGlue on MouseEvent {
/// A [Point] representation of the [clientX] and [clientY] properties
/// of this [MouseEvent].
///
/// **Deprecated:** Prefer directly accessing
/// the [clientX] and [clientY] properties on [MouseEvent].
@Deprecated('Instead directly access the clientX and clientY properties.')
Point get client => Point(clientX, clientY);
}

extension TouchGlue on Touch {
/// A [Point] representation of the [clientX] and [clientY] properties
/// of this [Touch] event.
///
/// **Deprecated:** Prefer directly accessing
/// the [clientX] and [clientY] properties on [Touch].
@Deprecated('Instead directly access the clientX and clientY properties.')
Point get client => Point(clientX, clientY);
}

Expand Down