Skip to content

Ensure the example application does not depend on dev SDK / packages #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
grouma opened this issue Sep 10, 2020 · 1 comment · Fixed by #1104
Closed

Ensure the example application does not depend on dev SDK / packages #1102

grouma opened this issue Sep 10, 2020 · 1 comment · Fixed by #1104

Comments

@grouma
Copy link
Member

grouma commented Sep 10, 2020

We use the example application for testing. Currently it depends on the dev release version of package:build_web_compilers. We should downgrade this dependency and add documentation to prevent future slip ups.
@grouma
Copy link
Member Author

grouma commented Sep 10, 2020

Note this could have prevented #1099

@grouma grouma mentioned this issue Sep 10, 2020
Merged
grouma added a commit that referenced this issue Sep 11, 2020
@grouma
Improved Smoke Tests for Webdev (#1104)
ca3e3db 
Closes #1102 and #1103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Smoke Tests for Webdev dart-lang/webdev
1 participant
@grouma