Skip to content

Improved Smoke Tests for Webdev #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 11, 2020
Merged

Improved Smoke Tests for Webdev #1104

merged 10 commits into from
Sep 11, 2020

Conversation

grouma
Copy link
Member

@grouma grouma commented Sep 10, 2020 •
edited
Loading

Closes #1102 and #1103

@grouma grouma requested a review from jakemac53 September 10, 2020 22:00
jakemac53
jakemac53 reviewed Sep 10, 2020
View reviewed changes
@jakemac53
Copy link
Contributor

We likely want to at least run the formatter/analyzer on this new dir.

@jakemac53
Copy link
Contributor

Closes #1102 and #1102

those are the same bug :D

@grouma
Copy link
Member Author

grouma commented Sep 10, 2020

Closes #1102 and #1102

those are the same bug :D

Oops. Fixed.

@grouma
Copy link
Member Author

grouma commented Sep 10, 2020

Should be good now. PTAL.

@grouma
Copy link
Member Author

grouma commented Sep 11, 2020

Merging on a red DWDS flake. This change had no impact on DWDS tests.

@grouma grouma merged commit ca3e3db into master Sep 11, 2020
@grouma grouma deleted the webdev-smoke branch September 11, 2020 00:40
@grouma grouma mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure the example application does not depend on dev SDK / packages
2 participants
@grouma @jakemac53