Skip to content

Verilog: fix for multi-ary binary primitive gates #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Verilog: fix for multi-ary binary primitive gates #885

merged 1 commit into from
Dec 16, 2024

Conversation

kroening
Copy link
Member

The Verilog binary primitive gates (or, and, etc.) can be multi-ary. This fixes the case when there are more than two inputs.

Fixes #880.

@kroening kroening force-pushed the fix-or1 branch 5 times, most recently from f06ea0e to ca1a253 Compare December 16, 2024 21:25
@kroening kroening marked this pull request as ready for review December 16, 2024 21:32

irep_idt id = instance.type().id() == ID_bool
? module
: dstringt{"bit" + id2string(module)};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: dstringt{"bit" + id2string(module)};
: irep_idt{"bit" + id2string(module)};

The Verilog binary primitive gates (or, and, etc.) can be multi-ary.  This
fixes the case when there are more than two inputs.
@kroening kroening merged commit 003138b into main Dec 16, 2024
9 checks passed
@kroening kroening deleted the fix-or1 branch December 16, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False possitive verification result
2 participants