Skip to content

Handling properties as @container as @list and @type as @id #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dankawka opened this issue Jun 29, 2017 · 2 comments
Closed

Handling properties as @container as @list and @type as @id #189

dankawka opened this issue Jun 29, 2017 · 2 comments

Comments

@dankawka
Copy link

Hello, recently I created an issue on json-ld.org repo, you can ready about it here: json-ld/json-ld.org#508

Also created PR with test for that which probably will fail for now as fixes are needed:
json-ld/json-ld.org#509
@adambro adambro mentioned this issue Aug 11, 2017
Merged
@adambro
Copy link

adambro commented Aug 15, 2017

Hi @davidlehn do you consider this a bug for JSON-LD 1.0 spec? As @gkellogg mentioned in comment at json-ld/json-ld.org/pull/510 it's up to implementations and he fixed that in Ruby lib already (see commit). Plus PHP version has been working as expected before this bug report.

I'd like to contribute a patch, but I'm a bot lost in the implementation to be honest. I thought the problem is in _selectTerm function, but it seems to be just before that function is called in _compactIri function. Is that good thinking? I'm asking because I don't see / recognise concepts mentioned in corrected algorithm (PR linked above) https://www.w3.org/TR/json-ld-api/#inverse-context-creation

adambro added a commit to adambro/jsonld.js that referenced this issue Aug 25, 2017
@adambro
Fix compacting empty list mapped @type: @id
3201e8c 
It sets default common type to `@id` for an empty list. Extracted from
existing algorithm where `@id` was a default type if list item was not a
value (empty is not a value).

The test case has been marked for 1.1 version of the spec, but has been
considered as an errata to 1.0 spec as well. See comment:
json-ld/json-ld.org#510 (comment)

This fixes digitalbazaar#189 issue.
@adambro adambro mentioned this issue Aug 25, 2017
Closed
@dlongley
Copy link
Member

Fixed by 7fcbdcd.

@adambro adambro mentioned this issue Nov 17, 2017
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compacting empty list mapped @type: @id adambro/jsonld.js
3 participants
@dlongley @adambro @dankawka