Skip to content

Allow empty lists to be compacted by any term with container @list #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jul 1, 2017

…that matches the property IRI:

  • Update inverse context to creation to include an @any member for the container member of container map for a given iri.
  • Update IRI Compaction to set type/language to @any if value is an empty list object.

Fixes #508. PR #509 is appropriate with this change.

…that matches the property IRI:

* Update inverse context to creation to include an `@any` member for the _container_ member of _container map_ for a given _iri_.
* Update IRI Compaction to set _type/language_ to `@any` if value is an empty list object.

Fixes #508. PR #509 is appropriate with this change.
@gkellogg gkellogg added the api label Jul 1, 2017
@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Jul 1, 2017
@gkellogg gkellogg self-assigned this Jul 1, 2017
@gkellogg gkellogg requested review from dlongley and lanthaler July 1, 2017 21:25
@gkellogg
Copy link
Member Author

gkellogg commented Jul 1, 2017

We might consider this as an erratum to 1.0.

@adambro
Copy link

adambro commented Aug 11, 2017

We might consider this as an erratum to 1.0.

@gkellogg is it actually a bug in json-ld 1.0 version? I'm asking because it's still present in digitalbazaar/jsonld.js#189 but apparently @davidlehn decided to skip tests marked for json-ld 1.1 milestone.

@gkellogg
Copy link
Member Author

What I meant by that is that we might consider that implementations update this behavior in their 1.0 processors outside of any plans to commit to 1.1 upgrades. That is entirely up to the implementors, and if there was a consensus agreement, we could propose to file it as a 1.0 erratum. So far, silence has been deafening; lobby your tool providers if you think this is important.

adambro added a commit to adambro/jsonld.js that referenced this pull request Aug 25, 2017
It sets default common type to `@id` for an empty list. Extracted from
existing algorithm where `@id` was a default type if list item was not a
value (empty is not a value).

The test case has been marked for 1.1 version of the spec, but has been
considered as an errata to 1.0 spec as well. See comment:
json-ld/json-ld.org#510 (comment)

This fixes digitalbazaar#189 issue.
@kyrias
Copy link

kyrias commented Oct 16, 2021

@gkellogg Bit late to the game, but I just ran into this while trying to get the JSON-LD test suite passing. While I don't particularly care which of them is done, I think that it should either be made an erratum, or compaction test #t0074 should be marked as an JSON-LD 1.1 test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants