Skip to content

PEP 554: Fix typo in marshal example code (#1229) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

dimitern
Copy link
Owner

@dimitern dimitern commented Nov 8, 2019

CLA signed; fixes python#1229.

Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link

You should make a PR against the upstream repo. :)

@dimitern
Copy link
Owner Author

dimitern commented Nov 8, 2019

@ericsnowcurrently Should I merge it then? First time.. 🥇

@dimitern
Copy link
Owner Author

dimitern commented Nov 8, 2019

Oops, yeah - sure :)

@dimitern dimitern merged commit 096a242 into master Nov 8, 2019
@ericsnowcurrently
Copy link

Your PR was against your own master branch, not upstream. :)

@dimitern dimitern deleted the dimitern-fix-1229 branch November 8, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP 554: Minor typo in example code: create_fifo->create_channel
2 participants