-
Notifications
You must be signed in to change notification settings - Fork 301
Avoid AttributeError
for PUT and PATCH methods when using APIView
#778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update my fork
As |
@sliverc both of these fields aren't set whenever you use default UPD: I think I should explain a little bit more. Nothing stops a user to define The problem here is that |
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 97.16% 97.21% +0.04%
==========================================
Files 55 55
Lines 2825 2874 +49
==========================================
+ Hits 2745 2794 +49
Misses 80 80
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Could you follow up by adding a test and changelog entry then? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This looks good.
AttributeError
for PUT and PATCH methods when using APIView
Fixes silenced AttributeError in the case when
lookup_url_kwarg
doesn't exist in a viewDescription of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS