-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update Distributed cache topic+sample #9129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d950f76
to
3cc3356
Compare
Updates Updates Updates Updates Updates Update
ff204ab
to
4acc869
Compare
@sebastienros could you have a look? |
Thanks @sebastienros ... see how it looks on the last commit. [EDIT] Has the Redis package changed for 2.2? ... I don't see it in the current (2.2) repo sample ... https://github.com/aspnet/Caching/blob/master/samples/RedisCacheSample/RedisCacheSample.csproj [DOUBLE EDIT] Do you have any objection to rolling NCache into the topic coverage? I wouldn't put it into the sample app ... just a section on how to wire it up similar to the way that Redis is handled with some basic instructions and a link over to their NuGet package and docs. This wouldn't be for this PR ... I would open an issue to do it later. I'm too 🏃🏃🏃😅 at the moment. |
Updates
535b759
to
b07a5c3
Compare
@scottaddie Perhaps, we should go ahead with UE. I made all of Sébastien's changes ... except for the 2.2 Redis package. I don't see another package with a different id/version. No rush on this btw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aspnetcore/performance/caching/distributed/samples/2.x/DistCacheSample/SampleApp.csproj
Show resolved
Hide resolved
I'm going to hold for a sec while I get more info on the double-reversal on |
@scottaddie Pending styles approval on #9186, but this looks pretty good. Look ma! ... no static assets! |
@scottaddie Before we merge this, let's get Dan's blessing on the styles. |
ok ... the 🙏 server gods (Dan!) 🙏 has blessed us. The styles will probably require some tweaking. We'll find out as we move forward dropping wwwroot and using this. |
Fixes #8702
Internal Review Topic