Skip to content

Update Distributed cache topic+sample #9129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2018
Merged

Update Distributed cache topic+sample #9129

merged 6 commits into from
Oct 24, 2018

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Oct 19, 2018

Fixes #8702

Internal Review Topic

  • The usual ...
    • Rotate the tires
    • Change the oil
    • Replace the pine tree air freshener
  • Simplifying the title to make it easier to find in the TOC
  • 🎉 Shiny new RP sample app 🎈 ... simpler, too ... an old skool caching demo compared to what we had there before.
  • Significant revision to the layout (sequence of sections/content)
  • I want to add NCache to the topic ... LATER ... let's NOT do that right now. I'm going to open an issue for the work unless there's an objection. For now, I add links to NCache.

@guardrex guardrex force-pushed the guardrex/dist-cache branch from d950f76 to 3cc3356 Compare October 19, 2018 17:57
Updates

Updates

Updates

Updates

Updates

Update
@guardrex guardrex force-pushed the guardrex/dist-cache branch from ff204ab to 4acc869 Compare October 19, 2018 18:05
@guardrex guardrex requested a review from pranavkm October 19, 2018 19:04
@pranavkm
Copy link
Contributor

@sebastienros could you have a look?

@guardrex guardrex removed the request for review from pranavkm October 19, 2018 19:21
@guardrex
Copy link
Collaborator Author

guardrex commented Oct 20, 2018

Thanks @sebastienros ... see how it looks on the last commit.

[EDIT] Has the Redis package changed for 2.2? ... I don't see it in the current (2.2) repo sample ...

https://github.com/aspnet/Caching/blob/master/samples/RedisCacheSample/RedisCacheSample.csproj

[DOUBLE EDIT] Do you have any objection to rolling NCache into the topic coverage? I wouldn't put it into the sample app ... just a section on how to wire it up similar to the way that Redis is handled with some basic instructions and a link over to their NuGet package and docs. This wouldn't be for this PR ... I would open an issue to do it later. I'm too 🏃🏃🏃😅 at the moment.

@guardrex guardrex force-pushed the guardrex/dist-cache branch from 535b759 to b07a5c3 Compare October 20, 2018 15:00
@guardrex guardrex requested a review from scottaddie October 23, 2018 19:30
@guardrex
Copy link
Collaborator Author

@scottaddie Perhaps, we should go ahead with UE. I made all of Sébastien's changes ... except for the 2.2 Redis package. I don't see another package with a different id/version.

No rush on this btw.

Copy link
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rick is removing source map files (see #9189). Please remove them here. I see a few in wwwroot. Also consider whether wwwroot really needs to be pushed. That's something we're going to start excluding via .gitignore again (to decrease repo size). See #9188.

@guardrex
Copy link
Collaborator Author

I'm going to hold for a sec while I get more info on the double-reversal on App package version and to find out if I can put a script tag into this sample so it doesn't feel like it was built in 1995. Yikes! 😄 lol

@guardrex guardrex changed the title Update Distributed cache topic+sample [WIP] Update Distributed cache topic+sample Oct 24, 2018
@guardrex guardrex added the WIP label Oct 24, 2018
@guardrex guardrex changed the title [WIP] Update Distributed cache topic+sample Update Distributed cache topic+sample Oct 24, 2018
@guardrex guardrex removed the WIP label Oct 24, 2018
@guardrex
Copy link
Collaborator Author

@scottaddie Pending styles approval on #9186, but this looks pretty good. Look ma! ... no static assets!

@guardrex
Copy link
Collaborator Author

@scottaddie Before we merge this, let's get Dan's blessing on the styles.

@guardrex guardrex added WIP and removed WIP labels Oct 24, 2018
@guardrex
Copy link
Collaborator Author

ok ... the 🙏 server gods (Dan!) 🙏 has blessed us.

The styles will probably require some tweaking. We'll find out as we move forward dropping wwwroot and using this.

@guardrex guardrex merged commit 36d5f81 into master Oct 24, 2018
@delete-merged-branch delete-merged-branch bot deleted the guardrex/dist-cache branch October 24, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants