[linker] Drop remaining System.xml preserve list #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original System.xml was copied from monotouch (monodroid/e5859791fc33dfcc88dca42de70b07f7f4191313). Xamarin.iOS doesn't have it any more and we have equal dynamic code to preserve API from System assembly (minus preservation of System.ComponentModel converters for Activator.CreateInstance, which we don't use IIRC) The only addition from monodroid/a055f1c498f7c4d5960cd1651c950604e9d9e6cc is handled by the above mentioned code. So we should be safe by removing this description XML file and save some more space.
radekdoulik
added
the
full-mono-integration-build
jonpryor
pushed a commit
that referenced
this pull request
Jun 19, 2020
Context: https://developer.android.com/android11 Changes: https://github.com/xamarin/monodroid/compare/6d05c4929db1ba12ba3a04174938256e435dbbd4...fb5542fa193d5daef1c907f172e0775f9ea4b0d2 * xamarin/monodroid@fb5542fa1 [Make.config] Update API-R to API-30 (#1102) API-30 has been enumified (8f9c638). Time to declare it stable! Set API-R as API-30, v11.0, and stable. Update unit test files so `$(TargetFrameworkVersion)`= v11.0 (API-30). Rename `src/Mono.Android/Profiles/api-R.params.txt` to `api-30.params.txt`, to match the stable API-level ID. Updated `tests/api-compatibility/acceptable-breakages-vReference.txt` because the default API compare will now be against `API-30`, not `API-29`, and we deliberately removed the `XxxConst` classes which were `[Obsolete]`d 5+ years ago in API-30, resulting in an intentional API break. TODO: * `jnimarshalmethod-gen.exe` tests were disabled as they ran into a [runtime crash][0]. Once the runtime crash is fixed, we need to update `src/Mono.Android/Test/Mono.Android-Tests.csproj` so that `$(AndroidGenerateJniMarshalMethods)` is True when `'$(HostOS)' == 'Darwin'`. [0]: dotnet/runtime#34389
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 20, 2020
Context: https://developer.android.com/android11 Changes: https://github.com/xamarin/monodroid/compare/4a0be740c371b0139aa6fa9d70ecfa2197e9bbb4...25c3dd1684d5fa08db9d1e3997add4da163517b0 * xamarin/monodroid@25c3dd16: [Make.config] Update API-R to API-30 (dotnet#1102) API-30 has been enumified (2aa4dd2). Time to declare it stable! Set API-R as API-30, v11.0, and stable. Update unit test files so `$(TargetFrameworkVersion)`= v11.0 (API-30). Rename `src/Mono.Android/Profiles/api-R.params.txt` to `api-30.params.txt`, to match the stable API-level ID. Updated `tests/api-compatibility/acceptable-breakages-vReference.txt` because the default API compare will now be against `API-30`, not `API-29`, and we deliberately removed the `XxxConst` classes which were `[Obsolete]`d 5+ years ago in API-30, resulting in an intentional API break. TODO: * `jnimarshalmethod-gen.exe` tests were disabled as they ran into a [runtime crash][0]. Once the runtime crash is fixed, we need to update `src/Mono.Android/Test/Mono.Android-Tests.csproj` so that `$(AndroidGenerateJniMarshalMethods)` is True when `'$(HostOS)' == 'Darwin'`. [0]: dotnet/runtime#34389
jonpryor
added a commit
that referenced
this pull request
Jun 20, 2020
Context: https://developer.android.com/android11 Changes: https://github.com/xamarin/monodroid/compare/4a0be740c371b0139aa6fa9d70ecfa2197e9bbb4...25c3dd1684d5fa08db9d1e3997add4da163517b0 * xamarin/monodroid@25c3dd16: [Make.config] Update API-R to API-30 (#1102) API-30 has been enumified (2aa4dd2). Time to declare it stable! Set API-R as API-30, v11.0, and stable. Update unit test files so `$(TargetFrameworkVersion)`= v11.0 (API-30). Rename `src/Mono.Android/Profiles/api-R.params.txt` to `api-30.params.txt`, to match the stable API-level ID. Updated `tests/api-compatibility/acceptable-breakages-vReference.txt` because the default API compare will now be against `API-30`, not `API-29`, and we deliberately removed the `XxxConst` classes which were `[Obsolete]`d 5+ years ago in API-30, resulting in an intentional API break. TODO: * `jnimarshalmethod-gen.exe` tests were disabled as they ran into a [runtime crash][0]. Once the runtime crash is fixed, we need to update `src/Mono.Android/Test/Mono.Android-Tests.csproj` so that `$(AndroidGenerateJniMarshalMethods)` is True when `'$(HostOS)' == 'Darwin'`. [0]: dotnet/runtime#34389 Co-authored-by: Jonathan Pobst <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original System.xml was copied from monotouch
(monodroid/e5859791fc33dfcc88dca42de70b07f7f4191313). Xamarin.iOS
doesn't have it any more and we have equal dynamic code to preserve
API from System assembly (minus preservation of System.ComponentModel
converters for Activator.CreateInstance, which we don't use IIRC)
The only addition from
monodroid/a055f1c498f7c4d5960cd1651c950604e9d9e6cc is handled by the
above mentioned code.
So we should be safe by removing this description XML file and save
some more space.