Mark API-30 as stable. #4830
Merged
Mark API-30 as stable. #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jpobst
force-pushed
the
stable-30
branch
3 times, most recently
from
d83a1b7 to
fb28b74
Compare
|
/azp run |
|
Pull request contains merge conflicts. |
jpobst
requested review from
dellis1972,
grendello,
jonathanpeppers and
jonpryor
as code owners
jpobst
changed the title
grendello
approved these changes
Jun 19, 2020
|
Squash-and-merge- Summary: Body: |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jun 20, 2020
Context: https://developer.android.com/android11 Changes: https://github.com/xamarin/monodroid/compare/4a0be740c371b0139aa6fa9d70ecfa2197e9bbb4...25c3dd1684d5fa08db9d1e3997add4da163517b0 * xamarin/monodroid@25c3dd16: [Make.config] Update API-R to API-30 (dotnet#1102) API-30 has been enumified (2aa4dd2). Time to declare it stable! Set API-R as API-30, v11.0, and stable. Update unit test files so `$(TargetFrameworkVersion)`= v11.0 (API-30). Rename `src/Mono.Android/Profiles/api-R.params.txt` to `api-30.params.txt`, to match the stable API-level ID. Updated `tests/api-compatibility/acceptable-breakages-vReference.txt` because the default API compare will now be against `API-30`, not `API-29`, and we deliberately removed the `XxxConst` classes which were `[Obsolete]`d 5+ years ago in API-30, resulting in an intentional API break. TODO: * `jnimarshalmethod-gen.exe` tests were disabled as they ran into a [runtime crash][0]. Once the runtime crash is fixed, we need to update `src/Mono.Android/Test/Mono.Android-Tests.csproj` so that `$(AndroidGenerateJniMarshalMethods)` is True when `'$(HostOS)' == 'Darwin'`. [0]: dotnet/runtime#34389
jonpryor
added a commit
that referenced
this pull request
Jun 20, 2020
Context: https://developer.android.com/android11 Changes: https://github.com/xamarin/monodroid/compare/4a0be740c371b0139aa6fa9d70ecfa2197e9bbb4...25c3dd1684d5fa08db9d1e3997add4da163517b0 * xamarin/monodroid@25c3dd16: [Make.config] Update API-R to API-30 (#1102) API-30 has been enumified (2aa4dd2). Time to declare it stable! Set API-R as API-30, v11.0, and stable. Update unit test files so `$(TargetFrameworkVersion)`= v11.0 (API-30). Rename `src/Mono.Android/Profiles/api-R.params.txt` to `api-30.params.txt`, to match the stable API-level ID. Updated `tests/api-compatibility/acceptable-breakages-vReference.txt` because the default API compare will now be against `API-30`, not `API-29`, and we deliberately removed the `XxxConst` classes which were `[Obsolete]`d 5+ years ago in API-30, resulting in an intentional API break. TODO: * `jnimarshalmethod-gen.exe` tests were disabled as they ran into a [runtime crash][0]. Once the runtime crash is fixed, we need to update `src/Mono.Android/Test/Mono.Android-Tests.csproj` so that `$(AndroidGenerateJniMarshalMethods)` is True when `'$(HostOS)' == 'Darwin'`. [0]: dotnet/runtime#34389 Co-authored-by: Jonathan Pobst <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set API-R as API-30, v11.0, and stable.
Notes:
monodroidbump https://github.com/xamarin/monodroid/pull/1102.jnimarshalmethod-gen.exebecause running it onmonoandroid11hits a crash in Mono trying to enumerate interfaces with default members: CoreCLR tests on Mono runtime : crash running reflection/DefaultInterfaceMethods/GetInterfaceMapConsumer/GetInterfaceMapConsumer.sh runtime#34389tests/api-compatibility/acceptable-breakages-vReference.txtbecause the default compare will now be againstAPI-30instead ofAPI-29, and we purposely removedxxxConstclasses we marked as[Obsolete]5+ years ago.