Skip to content

Conversation

mitchdenny
Copy link
Member

Description

Follow up to #7650. Renames WaitBehavior enumeration values and adopts Davids ShouldYield inner method.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 00:27
@mitchdenny mitchdenny self-assigned this Feb 19, 2025
@mitchdenny mitchdenny added the area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing label Feb 19, 2025
@mitchdenny mitchdenny added this to the 9.1 milestone Feb 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Hosting/ResourceBuilderExtensions.cs:741

  • Renamed WaitBehavior enumeration values to StopOnResourceUnavailable and WaitOnResourceUnavailable.
WaitFor(messaging, WaitBehavior.StopOnResourceUnavailable);

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just 2 comments on comments

@mitchdenny mitchdenny merged commit d8ab7d0 into main Feb 19, 2025
70 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/wait-behavior-follow-up branch February 19, 2025 01:18
@mitchdenny
Copy link
Member Author

/backport to release/9.1

Copy link
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13403420214

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-testing Issues pertaining to the APIs in Aspire.Hosting.Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants