Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 19, 2025

Backport of #7668 to release/9.1

/cc @mitchdenny

Customer Impact

This is a follow up to #7664. We decided to rename the enumeration values and made some changes to the logic (adopted from a prototype branch that @davidfowl put together).

Testing

Same test cases that already exist. This just renames the enumerations and tweaks the internal implementation of the method to use an inner method.

Risk

Low.

Regression?

@github-actions github-actions bot requested a review from mitchdenny as a code owner February 19, 2025 01:19
@mitchdenny mitchdenny self-assigned this Feb 19, 2025
@mitchdenny mitchdenny changed the title [release/9.1] Mitchdenny/wait-behavior-follow-up [release/9.1] Follow up to WaitForResourceHealthyAsync changes. Feb 19, 2025
@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Feb 19, 2025
@danmoseley danmoseley requested a review from eerhardt February 19, 2025 03:39
@mitchdenny mitchdenny added this to the 9.1 milestone Feb 19, 2025
@mitchdenny
Copy link
Member

/cc @wtgodbe

@davidfowl davidfowl merged commit 8ee2469 into release/9.1 Feb 19, 2025
5 checks passed
@davidfowl davidfowl deleted the backport/pr-7668-to-release/9.1 branch February 19, 2025 06:43
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants