-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Flaky test Microsoft.AspNetCore.Components.E2ETest.Tests.DownloadAnchorTest.DownloadFileFromAnchor #29739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hm -- this test has been passing since it was quarantined. I noticed that this particular failure occurred when the change to run all quarantined tests as CI runs was reverted so I wonder if that had something to do with it. Recommend we see if this can be unquarantined next week and then verifying if failures continue once it is running in the regular CI. Side-note: if we have a hypothesis that the environment the tests run on is affecting their flakiness then we should probably sort that out separately. |
Where are you seeing this? I'd expect to see it in the quarantine tests dashboard but I'm not finding it. |
Does this work for you? Also, looks like it got flaky again towards the end of last month. The bigger red bar is due to some issues with Selenium but the other incidents are repros of the flakiness. Bummer. :/ |
Ah got it, thanks! Yeah, looks like the flakiness has returned :/ |
Put in a fix for this. Not sure if we are supposed to be closing these now or once 30 days have passed but I'll close and we can re-open if need be. |
Well we made this test consistent, but probably not in the way we want, its been full red since 3/11 which I think maps to when you made this change 😢 |
Boo. Maybe we can we move this test to the new Playwright E2E tests project and use the Download APIs from Playwright? As seen in https://github.com/microsoft/playwright-sharp/blob/3709d37ab2badc7745d2fadc1ce7806e141702e8/src/PlaywrightSharp.Tests/DownloadsPathTests.cs#L25. |
Sure sounds like a good candidate for early conversion once its ready |
Moving this to Next sprint planning pending the Playwright move so we can use the APIs mentioned above. |
Thanks for contacting us. |
This is "Done" but was merged into the Playwright PR since the fix requires using some APIs that are only available in Playwright. Will close once that PR is merged into main. |
What PR is that? If it was merged, this test still has a 0% pass rate. |
@BrennanConroy It's #32428 |
The PR with the Playwright tests has now been merged. |
https://dev.azure.com/dnceng/public/_build/results?buildId=970420&view=ms.vss-test-web.build-test-results-tab&runId=30490800&resultId=100005&paneView=debug
Extension of tests quarantined in #29652 / #29698.
The text was updated successfully, but these errors were encountered: