-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Requarantine component tests #29652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requarantine component tests #29652
Conversation
EventDuringBatchRendering_CanTriggerDOMEvents() These have already failing again since they were unquarantined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's try this.
@TanayParikh please keep an eye out for additional tests we may need to quarantine in this area in particular.
Sounds good. @HaoK is this fine to merge now? |
Have you reopened all the linked issues? |
This comment has been minimized.
This comment has been minimized.
I'll create a new master issue and link them all to this one for now |
Hi @HaoK. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Hi @HaoK. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
* Quarantine E2E Test DownloadFileFromAnchor Extension of tests quarantined in #29652 / #29698. Failure: https://dev.azure.com/dnceng/public/_build/results?buildId=970420&view=ms.vss-test-web.build-test-results-tab&runId=30490800&resultId=100005&paneView=debug * Add using Microsoft.AspNetCore.Testing;
Roll back the component tests that were renabled in 3f7b205#diff-161948171825dc8c1b30fdc7c517d8e960d462359d1959cd30aa428ad16172f2