-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Blazor WebAssembly Project Template] Change web app manifest extension to “webmanifest” #43755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@christianliebel thanks for contacting us. I imagine you might be referring to the manifest used by PWAs? That would need to be handled at the static files level. @Tratcher do you have any thoughts? Would we be open to a PR that updates our mappings to support this? Do browsers follow the spec appropriately? What concrete, practical benefit does this change bring? |
Hi @christianliebel. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. |
@javiercn Correct, I'm referring to the Web Application Manifest used by PWAs. My PR #43756 would change the file extension of the manifest created by the project template to "webmanifest", its official extension.
Yes, the static files mapping could be adjusted to include the official media type |
@javiercn @Tratcher The media type is already included in the media type map: https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/StaticFiles/src/FileExtensionContentTypeProvider.cs#L347 So changing the file extension is sufficient. 😇 |
@christianliebel thanks for the clarification. I am fine if the change is benign. Which seems to be. |
@christianliebel we talked about this and we will take your PR for .NET 8.0 once it passes on the CI. Thanks for the contribution |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe the problem.
No response
Describe the solution you'd like
The official file extension for the Web Application Manifest is
webmanifest
. This helps servers to deliver the file with the official media type (application/manifest+json
). I propose changing the manifest's file extension in the Blazor WebAssembly project templates from "json" to "webmanifest".Sources:
Additional context
No response
The text was updated successfully, but these errors were encountered: