Update tests to reflect change of web app manifest extension in React C# template #43765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-mvc
|
Thanks for your PR, @christianliebel. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
christianliebel
force-pushed
the
webmanifest-ext-react
branch
from
25a4d9b to
42b18a0
Compare
|
Just merged dotnet/spa-templates#80. |
TanayParikh
requested review from
TanayParikh
and removed request for
Pilchie
TanayParikh
approved these changes
Jan 13, 2023
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@christianliebel could you please take a look at any additional potential test changes required now that dotnet/spa-templates#80 is merged? |
@dotnet/aspnet-build did I potential miss a build break? dotnet/spa-templates#80 was merged and should've automatically(?) been reflected in our aspnetcore builds due to the submodule setup? |
|
Thanks, will take a look |
|
Closing given #46122. Thanks @christianliebel! |
auto-merge was automatically disabled
January 24, 2023 19:48
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to reflect change of web app manifest extension in React C# template
Update tests when React C# template in spa-templates uses "webmanifest" as manifest extension
Description
The React project template in spa-templates uses "json" as the extension for the Web Application Manifest. "webmanifest" is the recommended one (see #43755 and #43756 for context). If dotnet/spa-templates#80 gets merged and the submodule updated, the tests in this repository will fail. This PR would fix them again.