-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Blazor WebAssembly] Change web app manifest extension to “webmanifest” #43756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your PR, @christianliebel. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests likely need to be updated and the docs might also need to be updated.
We should ping guardrex about the docs after this is merged.
7bd67bb
to
dcad845
Compare
dcad845
to
17fb058
Compare
@javiercn I have updated the tests. A Blazor Server test still fails because Let me know if you need any help with the docs. |
Hey @christianliebel, thanks for the PR. We're ready to take this in now. Could you please resolve the merge conflict, and I'll look into any CI flakiness if required. |
17fb058
to
140c76c
Compare
@TanayParikh Done! |
/azp run aspnetcore-quarantined-pr |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christianliebel! I think thats all the |
@TanayParikh Looks good, thanks!! |
Hi @christianliebel. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
[Blazor WebAssembly] Change web app manifest extension to “webmanifest”
Changes web app manifest extension from "json" to "webmanifest"
Description
Changes the extension of the web application manifest included by the Blazor WebAssembly project templates from "json" to "webmanifest", the official file extension. This helps servers to deliver the file with the official media type (
application/manifest+json
).Fixes #43755