Skip to content

Cache manifest.webmanifest in PWA #54953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
tomasz-soltysik opened this issue Apr 4, 2024 · 1 comment · Fixed by #59231
Closed
1 task done

Cache manifest.webmanifest in PWA #54953

tomasz-soltysik opened this issue Apr 4, 2024 · 1 comment · Fixed by #59231
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-pwa Issues related to building PWAs with Blazor help wanted Up for grabs. We would accept a PR to help resolve this issue triaged
Milestone
.NET 10 Planning

Comments

@tomasz-soltysik
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

After file extension change done in #43756, Web Manifest is no longer added to offline cache.
Prior to this change it had json extension which is included.

Expected Behavior

Web Manifest should be added to offline cache by default service worker implementation.

Steps To Reproduce

  • Create new project from Blazor template, with PWA option selected.
  • Run published app and let service worker install.
  • Check if manifest.webmanifest is in offline cache

Exceptions (if any)

No response

.NET Version

No response

Anything else?

Adding /\.webmanifest$/ to offlineAssetsInclude in service-worker.published.js should fix this.
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Apr 4, 2024
@mkArtakMSFT mkArtakMSFT added the feature-pwa Issues related to building PWAs with Blazor label Jul 3, 2024
@mkArtakMSFT mkArtakMSFT added bug This issue describes a behavior which is not expected - a bug. help wanted Up for grabs. We would accept a PR to help resolve this issue and removed investigate labels Nov 13, 2024
@mkArtakMSFT mkArtakMSFT modified the milestone: .NET 10 Planning Nov 13, 2024
@shethaadit
Copy link
Contributor

shethaadit commented Nov 30, 2024 •
edited
Loading

Hi @mkArtakMSFT, I will work on this and raise PR soon. Could you please assign this issue to me? :)

@shethaadit shethaadit mentioned this issue Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. feature-pwa Issues related to building PWAs with Blazor help wanted Up for grabs. We would accept a PR to help resolve this issue triaged
Projects
None yet
Milestone
.NET 10 Planning
Development

Successfully merging a pull request may close this issue.

Fix: Include .webmanifest in Offline Cache for Default PWA Service Worker shethaadit/aspnetcore
4 participants
@MackinnonBuck @shethaadit @tomasz-soltysik @mkArtakMSFT