Fix bug in CircuitManager #12209
Merged
Fix bug in CircuitManager #12209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
commented
Jul 15, 2019
rynowak
commented
Jul 15, 2019
This bug was introduced by removing the parsing from 8fa4df9 but not updating the tests. We expect component and rendererId to always be numbers (not strings). It looks like these tests are not currently running on the CI which was how we were able to find the issue.
rynowak
force-pushed
the
rynowak/fix-circuitmanager
branch
from
0b270aa to
87f0755
Compare
|
@javiercn updated |
javiercn
approved these changes
Jul 15, 2019
ghost
deleted the
Is there anything tracking the need to run these tests in CI? |
there is now #12231 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced by removing the parsing from
8fa4df9
It looks like these tests are not currently running on the CI which was
how we were able to find the issue.