Skip to content

[master] Also target netstandard2.1 for Identity.EFCore #13381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[master] Also target netstandard2.1 for Identity.EFCore #13381

wants to merge 2 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Aug 23, 2019

Fix for #13340

@HaoK HaoK requested review from ajcvickers and JunTaoLuo August 23, 2019 16:52
@HaoK
Copy link
Member Author

HaoK commented Aug 23, 2019

@JunTaoLuo I tried to mimic the changes you made in 88a3a74#diff-d5cb1079ed5b07e65dcc675f6e4b7ef3 can you double check I did it correctly?

@HaoK HaoK mentioned this pull request Aug 23, 2019
Closed
JunTaoLuo
JunTaoLuo approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall but you don't need the conditional for source build.

@Pilchie Pilchie added the area-identity Includes: Identity and providers label Aug 23, 2019
@JunTaoLuo
Copy link
Contributor

Should we submit this for 3.0 ask mode? Either preview9 or post preview9? cc @Pilchie

@Pilchie
Copy link
Member

Pilchie commented Aug 24, 2019

Yes, as for which - is there a workaround for affected customers? We don't have a lot of time to get things into Preview 9 builds at this point.

@HaoK
Copy link
Member Author

HaoK commented Aug 24, 2019

I don't think there is a workaround for this

@Pilchie
Copy link
Member

Pilchie commented Aug 24, 2019

Okay - can you target the release/3.0-preview9 branch and fill out the ask mode template. I'm not sure it'll get approved for P9, but we can try.

@HaoK HaoK added this to the 3.0.0-preview9 milestone Aug 24, 2019
@HaoK HaoK changed the base branch from master to release/3.0-preview9 August 24, 2019 00:46
@HaoK HaoK added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Aug 24, 2019
@HaoK HaoK changed the base branch from release/3.0-preview9 to master August 24, 2019 01:03
@HaoK
Copy link
Member Author

HaoK commented Aug 24, 2019

Rebase went poorly on this PR, created a new one for preview9 #13402

@HaoK HaoK modified the milestones: 3.0.0-preview9, 3.1.0 Aug 24, 2019
@HaoK HaoK removed the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Aug 24, 2019
@HaoK
Copy link
Member Author

HaoK commented Aug 24, 2019

I'll keep this PR around for master

@HaoK HaoK changed the title Also target netstandard2.1 for Identity.EFCore [master] Also target netstandard2.1 for Identity.EFCore Aug 24, 2019
@JunTaoLuo
Copy link
Contributor

Is there a need to keep this around? We should wait for bot to merge release/3.0 to master after we unblock #13182. I think we can close this now.

@HaoK
Copy link
Member Author

HaoK commented Aug 27, 2019

Sounds good

@HaoK HaoK closed this Aug 27, 2019
@HaoK HaoK deleted the identity-net21 branch December 5, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoK @JunTaoLuo @Pilchie