[3.0] Also target netstandard2.1 for Identity.EFCore #13402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
added
area-identity
HaoK
changed the title
|
@HaoK This is approved, but it looks like it's failing CI. Can you take a look? Or you @JunTaoLuo ? |
|
Looks like a flaky test again, I'll rerun that test, but doesn't look related at all as its a hosting shutdown test only on ubuntu |
|
Required checks in aspnetcore-ci look green now |
|
This was approved, merging. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #13340
The user/role features of identity (UserManager/RoleManager) are intended to continue working outside of ASP.NET for 3.0. Unfortunately we missed updating the Identity.EntityFrameworkCore store implementation package to target netstandard 2.1 (required for EF), so its currently only targeting netcoreapp3.0 (the default for ASP.NET Core). This change just enables this package to be target netstandard2.1.
Customer Impact
Customers are unable to use the default identity EF store implementation outside of netcoreapp3.0 which is also regression from 2.2
Regression?
Yes, in 2.2, this package targeted netstandard2.0
Risk
Low