Workaround template fix for incorrect file encoding when the first line is a conditional statement #18213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-mvc
DescriptionWhen creating a new Blazor project from template, App.razor is generated as ANSI instead of UTF-8. This is an issue with the templating engine which is tracked here. This PR contains the workaround until the underlying templating issue is fixed. Customer ImpactReported by two customers. Unicode characters in App.razor are not rendered in the browser correctly. How foundCustomer report Test coverageManually verified the workaround. Working on adding a recurring test to be run by vendors. Regression?Yes, from 3.0 to 3.1 RiskLow |
ajaybhargavb
added
the
Servicing-consider
ajaybhargavb
force-pushed
the
ajbaaska/workaround
branch
from
61285bb to
0e9abe0
Compare
ajaybhargavb
requested review from
analogrelay,
BrennanConroy,
dougbu,
halter73,
jkotalik,
SteveSandersonMS and
Tratcher
as code owners
ajaybhargavb
removed request for
analogrelay,
halter73,
SteveSandersonMS,
Tratcher,
dougbu,
BrennanConroy and
jkotalik
|
Suggest a quick re-title of this to explain better. "Workaround template fix for incorrect code page when conditionals are first line" |
ajaybhargavb
changed the title
mkArtakMSFT
added
Servicing-approved
|
This is approved by tactics for February release. I'll merge this when it's time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18058
This is a workaround for the issue dotnet/templating#2217.