Skip to content

Remove workaround for templating encoding issue #22367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2020
Merged

Remove workaround for templating encoding issue #22367

merged 1 commit into from
May 30, 2020

Conversation

ajaybhargavb
Copy link
Contributor

In #18213, we added a workaround for this issue. We no longer need it as the original issue is fixed now.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 29, 2020
@mkArtakMSFT
Copy link
Contributor

Thanks @ajaybhargavb. I assume we have validation in place that will now fail, if the templating engine fix is not correct?

@ajaybhargavb
Copy link
Contributor Author

I assume we have validation in place that will now fail, if the templating engine fix is not correct?

Yes, we a CTI scenario for this.

@ajaybhargavb ajaybhargavb merged commit 5c155d4 into master May 30, 2020
@ajaybhargavb ajaybhargavb deleted the ajbaaska/remove-workaround branch May 30, 2020 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajaybhargavb @mkArtakMSFT