Skip to content

Migrating from Extensions #19032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 527 commits into from
Closed

Migrating from Extensions #19032

wants to merge 527 commits into from

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Feb 13, 2020

For illustration purposes only. I'll open a separate PR with the necessary modifications on top of this migration to build and test.

dougbu and others added 30 commits August 11, 2019 14:12
- blocking aspnet/AspNetCoredotnet/extensions#1293 dependency update PR
- commit 3ec8c35e450c lost `AssemblyName` substitution
  - tasks assembly in package incorrectly named ".Manifest.Task.dll"
\n\nCommit migrated from dotnet/extensions@77403f3
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@3f8ee55
* Special case Disposing DotNetObjectReferences

This removes a public JSInvokable method required for disposing DotNetObjectReferences


\n\nCommit migrated from dotnet/extensions@d6bfc28
* API Review: JSRuntime

* Rename JSRuntimeBase -> JSRuntime
* Rename JSInProcessRuntimeBase -> JSInProcessRuntime
* Rename DotNetObjectRef -> DotNetObjectReference
* Update JSRuntime to return ValueTask
* Make InvokeAsync APIs that explicitly cancels and API that default cancels more crisp
* Introduce void invoking APIs
* Fixup method names on DotNetDispatcher

\n\nCommit migrated from dotnet/extensions@93d3ae4
* Remove the use of async local JSRuntime

* Update DotNetDispatcher to accept a JSRuntime instance rather than use a ambient value.
* Modify DotNetObjectReference to start tracking it's value during serialization.
\n\nCommit migrated from dotnet/extensions@ae9878b
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@65707ff
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@969f9a1
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@f8d29bc
…otnet/extensions#2210)

- unblocks work on aspnet/AspNetCoredotnet/extensions#4923
  - arguments for inside and outside men of service reference doc gen tool are mixed by default
  - users may add either argument type to the end of the outside man's command line
- e.g. "command --unexpected unexpectedValue --expected" can now set the "expected" option
  - only "--unexpected" and "unexpectedValue" are added to RemainingArguments in that case

- default behaviour of the command-line parser is unchanged to avoid breaking existing applications
- new switch is supported only when calling `CommandLineApplication` constructor for top-level commands
  - `dotnet-getdocument` (the outside man) has no (sub)commands and expanding scope would increase churn

nits: take VS suggestions in changed files\n\nCommit migrated from dotnet/extensions@e443397
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@14efea2
…ge/release/3.0-preview9-to-release/3.0

[automated] Merge branch 'release/3.0-preview9' => 'release/3.0'\n\nCommit migrated from dotnet/extensions@a459d9e
…ge/release/3.0-to-master

[automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@a070a81
- no-op merge, no reason to wait\n\nCommit migrated from dotnet/extensions@7f64f14
jkotalik and others added 19 commits January 15, 2020 09:44
…ge/release/3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1f26860
…ge/release/3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@dea81ef
…ge/release/3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1693e05
…ge/release/3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@1c2bd97
…ge/release/3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'\n\nCommit migrated from dotnet/extensions@302f677
* Remove Mono.WebAssembly.Interop


\n\nCommit migrated from dotnet/extensions@4ac4b19
@JunTaoLuo JunTaoLuo added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 13, 2020
@dougbu
Copy link
Contributor

dougbu commented Feb 14, 2020

Is the plan to add commits from #19033 into this PR? Would be good to avoid checking in something that can't compile e.g. MockHostTypes errors

@JunTaoLuo
Copy link
Contributor Author

No I don't plan on adding those commits into this PR. Instead, once that PR is completed and approved, I'll simply change #19033's base branch to master and merge. This branch is separated to make reviewing more streamlined between moving the files and resolving the infrastructure updates once the files are moved.

@JunTaoLuo
Copy link
Contributor Author

I've retargeted #19033 so there's no need to keep this open.

@JunTaoLuo JunTaoLuo closed this Feb 20, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/extensions branch May 22, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.