-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Migrating sources from dotnet/extensions #19033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
\n\nCommit migrated from dotnet/extensions@9c392a9
\n\nCommit migrated from dotnet/extensions@204a4ee
\n\nCommit migrated from dotnet/extensions@b791bce
\n\nCommit migrated from dotnet/extensions@2dd5bf8
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@969f9a1
- brings in new Arcade bits\n\nCommit migrated from dotnet/extensions@7005708
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@f8d29bc
…otnet/extensions#2210) - unblocks work on aspnet/AspNetCoredotnet/extensions#4923 - arguments for inside and outside men of service reference doc gen tool are mixed by default - users may add either argument type to the end of the outside man's command line - e.g. "command --unexpected unexpectedValue --expected" can now set the "expected" option - only "--unexpected" and "unexpectedValue" are added to RemainingArguments in that case - default behaviour of the command-line parser is unchanged to avoid breaking existing applications - new switch is supported only when calling `CommandLineApplication` constructor for top-level commands - `dotnet-getdocument` (the outside man) has no (sub)commands and expanding scope would increase churn nits: take VS suggestions in changed files\n\nCommit migrated from dotnet/extensions@e443397
…/3.0\n\nCommit migrated from dotnet/extensions@5c41636
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@14efea2
…ge/release/3.0-preview9-to-release/3.0 [automated] Merge branch 'release/3.0-preview9' => 'release/3.0'\n\nCommit migrated from dotnet/extensions@a459d9e
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@a070a81
- no-op merge, no reason to wait\n\nCommit migrated from dotnet/extensions@7f64f14
…/3.0\n\nCommit migrated from dotnet/extensions@07c506d
…ns#2226) - no-op merge\n\nCommit migrated from dotnet/extensions@44f2dd8
- no-op merge\n\nCommit migrated from dotnet/extensions@8f37920
- no-op merge\n\nCommit migrated from dotnet/extensions@39d5064
- brings newer Arcade\n\nCommit migrated from dotnet/extensions@4afab35
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@12a28e4
\n\nCommit migrated from dotnet/extensions@033ea04
…ge/release/3.0-to-master [automated] Merge branch 'release/3.0' => 'master'\n\nCommit migrated from dotnet/extensions@d8590b1
\n\nCommit migrated from dotnet/extensions@ae9d51f
@@ -2,12 +2,13 @@ | |||
|
|||
<PropertyGroup> | |||
<Description>A simple object pool implementation.</Description> | |||
<TargetFramework>netstandard2.0</TargetFramework> | |||
<TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Waiting for #19122 |
- Multi-target ObjectPool - Move Embedded.Manifest.Task.Internal.Entry to the public namespace - Remove ref assemblies from AspNetCore.Testing - Skip TestPathUtilitiesTest since it's a pattern we want to migrate away from - Fix FileProviders.Abstractions version in Embedded.*.nuspec - Add workarounds for project references to FileProviders.Embedded
b180f84
to
7d1f5d8
Compare
…tcore into johluo/migrating-extensions
@javiercn @SteveSandersonMS who can help me take a look at the Blazor Template tests failures? I can't seem to run the tests locally so I can't debug the failure described in the CI test logs. |
It turns out there are binlogs captured on the CI, so I might be unblocked. |
@JunTaoLuo Please let us know if you still need assistance after checking those logs. Today was the final day before code-complete for the current Blazor milestone, so Javier and I were working pretty furiously on that, hence not responding sooner. Hope that's OK! |
Turns out it's an issue with ref packs again. I'll look into a fix. This PR might need some additional verification. |
@dotnet/aspnet-build can y'all look at this again before I merge? I'll also try to compare the ref pack outputs to ensure we didn't miss anything. |
I verified the ref packs and everything looks good |
@@ -94,14 +78,17 @@ and are generated based on the last package release. | |||
<LatestPackageReference Include="System.Net.Http" Version="$(SystemNetHttpPackageVersion)" /> | |||
<LatestPackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataPackageVersion)" /> | |||
<LatestPackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="$(SystemRuntimeCompilerServicesUnsafePackageVersion)" /> | |||
<LatestPackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="$(SystemRuntimeInteropServicesRuntimeInformationPackageVersion)" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding - these were packages that (previously) Extensions depended on, but not this repo? And now we're adding a dependency on them since we're bringing in the Extensions stuff that uses them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra changes look reasonable -
This PR is made on top of #19032 to simplify reviews. When approved, the changes in both PRs will be merged into master.
Update: all build/test issues have been resolved and I have re-targeted the base branch to master, I'll add more details in the PR description but this is ready to be merged.
Components being migrated:
Note that I anticipate that we will need to address a few more issues in collaboration with the dotnet/runtime team. Specifically:
I'll work with @maryamariyan on the dotnet side to address the remaining concerns once there is progress on that side.