Remove dependencies on packages we build here #19375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores automated dependency from into this repo. #19003 migrated some dependencies into this repo but did not update the version files. This caused generation to dependency PRs to fail. This change fixes the dependency tracking and manually updates dependencies.
ghost
added
the
area-infrastructure
rynowak
commented
Feb 26, 2020
| </Dependency> | ||
| <Dependency Name="Microsoft.Extensions.Options.DataAnnotations" Version="5.0.0-preview.2.20121.3" CoherentParentDependency="Microsoft.AspNetCore.Razor.Language"> |
There was a problem hiding this comment.
The diff is bad here because XML. The list of things I removed is based on the package list in 19033.
If there were still 'extra' references then the dependency update would fail, so I know I got them all.
dougbu
approved these changes
Feb 26, 2020
JunTaoLuo
suggested changes
Feb 26, 2020
So if I understand you correctly, these are still published from extensions, but we don't actually depend on them? |
|
Yes |
This code has already migrated to this repo. The extensions repo still publishes these packages, but they are not consumed here. Removing the references from dependency lists will avoid a future break when they go away from extensions.
|
@JunTaoLuo updated |
JunTaoLuo
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores automated dependency from into this repo.
#19033 migrated some dependencies into this repo but
did not update the version files. This caused generation to dependency
PRs to fail.
This change fixes the dependency tracking and manually updates
dependencies.
@JunTaoLuo