Skip to content

Revert AuthenticationAddXyz overload changes #24125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert AuthenticationAddXyz overload changes #24125

wants to merge 3 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 20, 2020

Fixes #24048

@HaoK HaoK added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jul 20, 2020
@HaoK HaoK marked this pull request as ready for review July 21, 2020 18:21
@HaoK HaoK requested a review from Tratcher as a code owner July 21, 2020 18:21
@HaoK HaoK added this to the 5.0.0-rc1 milestone Jul 21, 2020
@Tratcher
Copy link
Member

Preview 8?

Tratcher
Tratcher approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get rebased into preview8. Better to make a breaking change before RC. It will need a breaking change announcement as well, people have already started using these.

@HaoK
Copy link
Member Author

HaoK commented Jul 23, 2020

Okay I'll create a new preview8 PR

@HaoK HaoK closed this Jul 23, 2020
@HaoK HaoK mentioned this pull request Jul 23, 2020
Merged
@HaoK HaoK deleted the haok/rev branch August 12, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

Fix regression in auth options registration singleton->transient
2 participants
@HaoK @Tratcher