Skip to content

Revert AuthenticationAddXyz overload changes #24253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Revert AuthenticationAddXyz overload changes #24253

merged 1 commit into from
Jul 23, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 23, 2020

Replaces #24125

Fixes #24048

@HaoK
Revert AuthenticationAddXyz overload changes
cf3141d 
Update CertificateAuthenticationExtensions.cs

Update Startup.cs
@HaoK HaoK requested a review from Tratcher as a code owner July 23, 2020 20:41
@HaoK HaoK added this to the 5.0.0-preview8 milestone Jul 23, 2020
@HaoK HaoK added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Jul 23, 2020
@ghost
Copy link

ghost commented Jul 23, 2020

Hello @HaoK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 52 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 23, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview8 is a protected branch and I have not been granted permission to perform the merge.

@HaoK HaoK requested a review from a team July 23, 2020 21:51
@HaoK
Copy link
Member Author

HaoK commented Jul 23, 2020

Protected branch, can someone on the build team do the honors for us?

@ghost
Copy link

ghost commented Jul 23, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview8 is a protected branch and I have not been granted permission to perform the merge.

@Pilchie Pilchie merged commit 697b397 into release/5.0-preview8 Jul 23, 2020
@Pilchie Pilchie deleted the haok/p8auth branch July 23, 2020 22:00
@captainsafia captainsafia mentioned this pull request Aug 5, 2020
Merged
@juantxorena juantxorena mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoK @Tratcher @Pilchie