-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Revert identity package workaround and bump versions #24819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -23,8 +23,6 @@ | |||
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="${MicrosoftEntityFrameworkCoreSqlServerPackageVersion}" Condition=" '$(IndividualLocalAuth)' == 'True' AND '$(UseLocalDB)' == 'True'" /> | |||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="${MicrosoftEntityFrameworkCoreSqlitePackageVersion}" Condition=" '$(IndividualLocalAuth)' == 'True' AND '$(UseLocalDB)' != 'True'" /> | |||
<PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="${MicrosoftEntityFrameworkCoreToolsPackageVersion}" Condition=" '$(IndividualLocalAuth)' == 'True' " /> | |||
<PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="${MicrosoftAspNetCoreAuthenticationJwtBearerPackageVersion}" Condition=" '$(IndividualB2CAuth)' == 'True' OR '$(OrganizationalAuth)' == 'True'" NoWarn="NU1605"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What package version will the tests get now and from where? The latest version on nuget? The latest in a local feed? The one produced in the same build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll use the latest version on NuGet. We'll want to merge this PR after preview8 ships (added a note about this in the PR description).
Edit: the tests will always use the local build. The published bits will use the latest version on NuGet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When preview 8 ships.
b04e90f
to
f40b3d1
Compare
Thanks for the PR, @captainsafia. It looks like there is a separate PR which takes this a step further. Should we take that one instead: https://github.com/dotnet/aspnetcore/pull/25309/files |
@mkArtakMSFT We still need this PR because it removes the workaround in the project files for the templates so we'll have to merge both PRs. |
Thanks Safia! |
Reverts the workaround for identity package dependency mismatch that was introduced in #24600 and updates the package versions.
We should merge this after preview8 is released.
Addresses #24657