Add docs for remaining security items #26827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Google / Facebook / Microsoft Account auth * Authorization, Authorization.Policy Contributes to #26397
ghost
added
the
pranavkm
added
the
tell-mode
Tratcher
reviewed
Oct 13, 2020
| public MicrosoftChallengeProperties(IDictionary<string, string> items, IDictionary<string, object> parameters) | ||
| : base(items, parameters) | ||
| { } | ||
|
|
||
| /// <summary> | ||
| /// The "response_mode" parameter value being used for a challenge request. | ||
| /// Gets or sets the value for the <c>response_mode</c> parameter used for a challenge request. The response mode specifies the method | ||
| /// that should be used to send the resulting token back to the app. Can be one of the following: <c>query</c>, <c>fragment</c>, <c>form_post</c>. |
There was a problem hiding this comment.
Umm, I think I blindly add all the parameters from https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#request-an-authorization-code
There was a problem hiding this comment.
@Tratcher should we document that configuring this property isn't recommended?
There was a problem hiding this comment.
Nobody's noticed since it was introduced in 3.0. We can obsolete it in 6.0.
There was a problem hiding this comment.
@Kahbazi would you like to file an issue and/or send a PR?
pranavkm
commented
Oct 13, 2020
src/Security/Authentication/MicrosoftAccount/src/MicrosoftChallengeProperties.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Ross <[email protected]>
HaoK
reviewed
Oct 14, 2020
src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs
Outdated
Show resolved
Hide resolved
HaoK
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #26397