Obsolete ResponseMode in MicrosoftChallengeProperties #26938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Tratcher
reviewed
Oct 15, 2020
src/Security/Authentication/MicrosoftAccount/src/MicrosoftChallengeProperties.cs
Show resolved
Hide resolved
Tratcher
approved these changes
Oct 15, 2020
|
Hello @Tratcher! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Thanks |
ghost
merged commit 
|
We usually point to a url explaining why we deprecated something and provide an alternative. |
|
In this case I don't think much explanation is warranted. The property was introduced by mistake, never worked for anything but the default value, can't be made to work, and was never reported as broken by a customer so it seems it was never used. The only alternative API is to switch to the OIDC package. |
|
So in theory nobody ever used this property |
|
Not that we know of. We only noticed the issue when updating the doc comments. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
ResponseModesince only the default value is supported in Microsoft Account authentication.@Tratcher