Add pause between computing lastModified date and executing task #27073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
We discussed a few options for addressing this flakiness during the engineering sync including:
Pinging @dotnet/aspnet-blazor-eng to close on the final choice between the two. I'm leaning towards #3 if it's reasonable. |
captainsafia
changed the title
pranavkm
approved these changes
Nov 3, 2020
|
Hello @captainsafia! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
…net/aspnetcore#27073) * Use FileSystemWatcher to check if file was modified * Update ConcatenateFilesTest.cs * Update ConcatenateFilesTest.cs * Update ConcatenateFilesTest.cs * Update ConcatenateFilesTest.cs * Update ConcatenateFilesTest.cs * Update ConcatenateFilesTest.cs * Use Task.Delay Commit migrated from dotnet/aspnetcore@24b34d720366
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25623
Instead of checking the last modified date on the file to check it was modified, this PR uses an FS watcher to check if the file has been changed, making it more defensive towards any issues that come up with the last write time on the file.
Edit: This uses a wait now.