Skip to content

Add pause between computing lastModified date and executing task #27073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8 commits merged into from
Nov 3, 2020
Merged

Add pause between computing lastModified date and executing task #27073

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
320c7a9
Use FileSystemWatcher to check if file was modified
captainsafia Oct 20, 2020
1dd877a
Update ConcatenateFilesTest.cs
captainsafia Oct 20, 2020
607338f
Update ConcatenateFilesTest.cs
captainsafia Oct 21, 2020
329ce8c
Update ConcatenateFilesTest.cs
captainsafia Oct 21, 2020
618e384
Update ConcatenateFilesTest.cs
captainsafia Nov 2, 2020
1a8f631
Update ConcatenateFilesTest.cs
captainsafia Nov 2, 2020
5b6631b
Update ConcatenateFilesTest.cs
captainsafia Nov 2, 2020
f7480db
Use Task.Delay
captainsafia Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Razor/Microsoft.NET.Sdk.Razor/test/ConcatenateFilesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public void BundlesScopedCssFiles_DoesNotOverrideBundleForSameContents()

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25623")]
public void BundlesScopedCssFiles_UpdatesBundleWhenContentsChange()
public async System.Threading.Tasks.Task BundlesScopedCssFiles_UpdatesBundleWhenContentsChange()
{
// Arrange
var expectedFile = Path.Combine(Directory.GetCurrentDirectory(), $"{Guid.NewGuid():N}.css");
Expand Down Expand Up @@ -382,14 +382,14 @@ public void BundlesScopedCssFiles_UpdatesBundleWhenContentsChange()
}),
};

await System.Threading.Tasks.Task.Delay(1000);
taskInstance.Execute();

// Assert
Assert.True(result);
Assert.True(File.Exists(expectedFile));
var actualContents = File.ReadAllText(expectedFile);
Assert.Equal(UpdatedBundleContent, actualContents, ignoreLineEndingDifferences: true);

Assert.NotEqual(lastModified, File.GetLastWriteTimeUtc(expectedFile));
}
}
Expand Down