Skip to content

Quarantine Microsoft.AspNetCore.Components.E2ETests #29651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 26, 2021

@wtgodbe wtgodbe requested review from a team January 26, 2021 23:37
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 26, 2021
@HaoK
Copy link
Member

HaoK commented Jan 26, 2021

@dotnet/aspnet-blazor-eng this seems pretty risky to quarantine all component tests, would we have any pr validation of components at all if we quarantine the whole project?

In practice I believe this would basically mean as long as the PR for a change in components compiles, it would be green :)

@pranavkm
Copy link
Contributor

@HaoK are you able to figure out if this is a infrastructure / product / dependency issue? It's very worrying to quarantine all of Blazor's end-to-end test coverage.

@captainsafia
Copy link
Member

There was a thread on this over on the Teams channel. Apparently, these tests have been failing frequently since the 22nd.

We triaged the issue for this for preview2, but not sure when it will be assigned/worked on.

It's very worrying to quarantine all of Blazor's end-to-end test coverage.

Ditto. If we can figure out the root issue soon, we can address instead of quarantining. If not, I'm favor of quarantining and following up with the fix. Especially because aggressive failures here will end up increasing the amount of time people need to wait before being able to merge their PRs.

Is it possible that these failures are related to the recent changes in component tests?

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

Do we think the jump in failures might be related to the unquarantine of a bunch of tests in 3f7b205#diff-161948171825dc8c1b30fdc7c517d8e960d462359d1959cd30aa428ad16172f2 that was 6 days ago?

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

Maybe we just try rolling back that PR as a first step to see if that brings us back to a better place?

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

I opened #29652 to see if that helps, basically it requarantines only the component tests in that commit

@captainsafia
Copy link
Member

Are they the same tests that are currently failing?

I'd find it rather surprising if the tests currently failing are the ones that were unquarantined since they would've had to pass the 30+ days passing requirement.

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

I think maybe we should tweak our quarantined runs to run all tests not just quarantined tests, it wouldn't be surprising if there are tests that behave differently when we only run a small set of tests, we for sure would miss any poorly written tests that affect other tests intentionally or not.

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

But at this point it seems like we have the pretty bad options of just not testing components at all, or trying to rollback to some kind of known good state.

@HaoK
Copy link
Member

HaoK commented Jan 27, 2021

At least 3 of the 10 component tests that failed in the last week were in the batch we recently unquarantined:

EventDuringBatchRendering_CanTriggerDOMEvents()
BubblingStandardEvent_FiredOnElementWithoutHandler
CanUploadAndConvertImageFile

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Jan 27, 2021

@wtgodbe thanks for the PR. Let's take the PR @HaoK has instead. We want to continue improving the stability here and this won't help much.

@wtgodbe wtgodbe closed this Jan 27, 2021
@wtgodbe wtgodbe deleted the wtgodbe/QuarComp branch January 27, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants