Skip to content

fix 'conect' typo #30558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix 'conect' typo #30558

wants to merge 1 commit into from

Conversation

IsQiao
Copy link

@IsQiao IsQiao commented Mar 2, 2021

PR Title
Fix "conect" typo

PR Description

  • Fix "conect" typo in solution

@IsQiao IsQiao requested review from BrennanConroy, halter73 and a team as code owners March 2, 2021 01:46
@dnfadmin
Copy link

dnfadmin commented Mar 2, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just add comments on both typos saying they wont be fixed as they are breaking changes and not important enough to make a breaking change.

That will hopefully help people avoid opening PRs for the typos in the future 😄

@@ -14,7 +14,7 @@ public class ConnectionOptionsSetup : IConfigureOptions<ConnectionOptions>
/// <summary>
/// Default timeout value for disconnecting idle connections.
/// </summary>
public static TimeSpan DefaultDisconectTimeout = TimeSpan.FromSeconds(15);
public static TimeSpan DefaultDisconnectTimeout = TimeSpan.FromSeconds(15);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've previously discussed changing this and decided it's not worth making a breaking change here.
#18494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants