Skip to content

fix 'conect' typo #30558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix 'conect' typo #30558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/test/E2ETest/Tests/WebAssemblyAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class WebAssemblyAuthenticationTests : ServerTestBase<AspNetSiteServerFix
{
private static readonly SqliteConnection _connection;

// We create a conection here and open it as the in memory Db will delete the database
// We create a connection here and open it as the in memory Db will delete the database
// as soon as there are no open connections to it.
static WebAssemblyAuthenticationTests()
{
Expand Down
4 changes: 2 additions & 2 deletions src/SignalR/common/Http.Connections/src/ConnectionOptionsSetup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ConnectionOptionsSetup : IConfigureOptions<ConnectionOptions>
/// <summary>
/// Default timeout value for disconnecting idle connections.
/// </summary>
public static TimeSpan DefaultDisconectTimeout = TimeSpan.FromSeconds(15);
public static TimeSpan DefaultDisconnectTimeout = TimeSpan.FromSeconds(15);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've previously discussed changing this and decided it's not worth making a breaking change here.
#18494


/// <summary>
/// Sets default values for options if they have not been set yet.
Expand All @@ -24,7 +24,7 @@ public void Configure(ConnectionOptions options)
{
if (options.DisconnectTimeout == null)
{
options.DisconnectTimeout = DefaultDisconectTimeout;
options.DisconnectTimeout = DefaultDisconnectTimeout;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.Log.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ internal static class Log
LoggerMessage.Define<HttpTransportType>(LogLevel.Trace, new EventId(11, "ReceivedDeleteRequestForUnsupportedTransport"), "Received DELETE request for unsupported transport: {TransportType}.");

private static readonly Action<ILogger, Exception?> _terminatingConnection =
LoggerMessage.Define(LogLevel.Trace, new EventId(12, "TerminatingConection"), "Terminating Long Polling connection due to a DELETE request.");
LoggerMessage.Define(LogLevel.Trace, new EventId(12, "TerminatingConnection"), "Terminating Long Polling connection due to a DELETE request.");

private static readonly Action<ILogger, string, Exception?> _connectionDisposedWhileWriteInProgress =
LoggerMessage.Define<string>(LogLevel.Debug, new EventId(13, "ConnectionDisposedWhileWriteInProgress"), "Connection {TransportConnectionId} was disposed while a write was in progress.");
Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public HttpConnectionManager(ILoggerFactory loggerFactory, IHostApplicationLifet
_logger = loggerFactory.CreateLogger<HttpConnectionManager>();
_connectionLogger = loggerFactory.CreateLogger<HttpConnectionContext>();
_nextHeartbeat = new TimerAwaitable(_heartbeatTickRate, _heartbeatTickRate);
_disconnectTimeout = connectionOptions.Value.DisconnectTimeout ?? ConnectionOptionsSetup.DefaultDisconectTimeout;
_disconnectTimeout = connectionOptions.Value.DisconnectTimeout ?? ConnectionOptionsSetup.DefaultDisconnectTimeout;

// Register these last as the callbacks could run immediately
appLifetime.ApplicationStarted.Register(() => Start());
Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/common/Http.Connections/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ static Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilderExtensions.Map
static Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilderExtensions.MapConnectionHandler<TConnectionHandler>(this Microsoft.AspNetCore.Routing.IEndpointRouteBuilder! endpoints, string! pattern, System.Action<Microsoft.AspNetCore.Http.Connections.HttpConnectionDispatcherOptions!>? configureOptions) -> Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilder!
static Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilderExtensions.MapConnections(this Microsoft.AspNetCore.Routing.IEndpointRouteBuilder! endpoints, string! pattern, Microsoft.AspNetCore.Http.Connections.HttpConnectionDispatcherOptions! options, System.Action<Microsoft.AspNetCore.Connections.IConnectionBuilder!>! configure) -> Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilder!
static Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilderExtensions.MapConnections(this Microsoft.AspNetCore.Routing.IEndpointRouteBuilder! endpoints, string! pattern, System.Action<Microsoft.AspNetCore.Connections.IConnectionBuilder!>! configure) -> Microsoft.AspNetCore.Builder.ConnectionEndpointRouteBuilder!
static Microsoft.AspNetCore.Http.Connections.ConnectionOptionsSetup.DefaultDisconectTimeout -> System.TimeSpan
static Microsoft.AspNetCore.Http.Connections.ConnectionOptionsSetup.DefaultDisconnectTimeout -> System.TimeSpan
static Microsoft.AspNetCore.Http.Connections.HttpConnectionContextExtensions.GetHttpContext(this Microsoft.AspNetCore.Connections.ConnectionContext! connection) -> Microsoft.AspNetCore.Http.HttpContext?
static Microsoft.Extensions.DependencyInjection.ConnectionsDependencyInjectionExtensions.AddConnections(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
static Microsoft.Extensions.DependencyInjection.ConnectionsDependencyInjectionExtensions.AddConnections(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<Microsoft.AspNetCore.Http.Connections.ConnectionOptions!>! options) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!