Skip to content

Update selenium version #30576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 commits merged into from
Mar 3, 2021
Merged

Update selenium version #30576

5 commits merged into from
Mar 3, 2021

Conversation

JunTaoLuo
Copy link
Contributor

Part of https://github.com/dotnet/aspnetcore-internal/issues/3777

I'm hoping we can move to using Playwright asap so we don't have to make these types of changes.

@JunTaoLuo JunTaoLuo requested a review from dougbu as a code owner March 2, 2021 19:52
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 2, 2021
@JunTaoLuo JunTaoLuo requested review from a team and removed request for dougbu March 2, 2021 19:52
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiercn I don't see anything using the $(Selenium*) properties. Did you leave them behind for a reason❔ If not, can anything else from our Selenium history that could be deleted❔

@JunTaoLuo I suggest repurposing this PR to remove the $(Selenium*) properties and whatever else @javiercn says can go.

Please also update the ops rotation docs and issue template. @javiercn should something be done with the $(Playwright*) properties on a regular basis❔

@JunTaoLuo
Copy link
Contributor Author

I was wondering about that since I still see Selenium used in https://github.com/dotnet/aspnetcore/blob/main/src/Servers/Kestrel/test/Interop.FunctionalTests/Interop.FunctionalTests.csproj#L27-L28. I think only the blazor template tests and some other tests have been converted to using Playwright, not the entire repo.

@javiercn
Copy link
Member

javiercn commented Mar 2, 2021

@dougbu Components still uses Selenium.

@dougbu
Copy link
Contributor

dougbu commented Mar 2, 2021

More generally, any changes expecting to grab new versions from NuGet must be coordinated with @mmitche, @wtgodbe, or DncEng. Must get the new packages into the dotnet-public feed prior to submitting PRs like this one.

@JunTaoLuo
Copy link
Contributor Author

Yup, I just remembered we don't get packages from NuGet directly.

@dougbu
Copy link
Contributor

dougbu commented Mar 2, 2021

Ah, my bad on thinking the properties should be removed. Do we also need to get new Playwrite versions❔

@javiercn
Copy link
Member

javiercn commented Mar 2, 2021

@dougbu to a Degree, but we are still figuring out how often we want to update.

Playwright releases at the same cadence as Chrome, but a given version targets a fixed version of Chrom(ium) so as long as we don't stay behind for a year we are likely ok. We can always target a new browser version with an older driver, but compatibility is not guaranteed in that case.

@JunTaoLuo
Copy link
Contributor Author

I think that was the rationale for us to upgrade Selenium versions as part of Ops rotation. It's a preventative measure so that we are not blindsided by any chrome/driver incompatibilities. Is there harm in updating too frequently @javiercn ?

@dougbu
Copy link
Contributor

dougbu commented Mar 2, 2021

It's a preventative measure so that we are not blindsided by any chrome/driver incompatibilities.

Agreed. We don't have control over the Chrome version eng\scripts\InstallGoogleChrome.ps1 installs because the download URI is not version-specific.

@javiercn
Copy link
Member

javiercn commented Mar 2, 2021

Agreed. We don't have control over the Chrome version eng\scripts\InstallGoogleChrome.ps1 installs because the download URI is not version-specific.

Chrome doesn't offer version specific stuff for these things, once a new version is out is "impossible" to download the older version bits (I tried at some point).

@ghost
Copy link

ghost commented Mar 3, 2021

Hello @JunTaoLuo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@JunTaoLuo
Copy link
Contributor Author

FYI, I'll edit the doc to include updating Playwright when this PR passes.

@JunTaoLuo
Copy link
Contributor Author

Hmmm there was a complication with the playwright version update complaining that the driver executable can’t be found. I’ve reverted that to unblock the selenium update.

@ghost ghost merged commit 1372162 into main Mar 3, 2021
@ghost ghost deleted the johluo/selenium-update branch March 3, 2021 06:30
TanayParikh pushed a commit that referenced this pull request Mar 3, 2021
* Update selenium version

* Update more versions

* Update Versions.props

* Update selenium-config.json

* Update Versions.props
TanayParikh added a commit that referenced this pull request Mar 5, 2021
* Update selenium version

* Update more versions

* Update Versions.props

* Update selenium-config.json

* Update Versions.props

Co-authored-by: John Luo <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants