Backport selenium fix dotnet/aspnetcore#30576 to 5.0 #30621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update selenium version * Update more versions * Update Versions.props * Update selenium-config.json * Update Versions.props
|
@JunTaoLuo / @dougbu can this be merged? |
Pilchie
added
the
area-infrastructure
dougbu
approved these changes
Mar 4, 2021
Definitely❕ |
|
My bad. Should have reminded you to wait 'til branch was open for this. @wtgodbe will this 'release/5.0' change cause CQB issues❔ |
|
Thanks for catching it quickly, just need to cancel the build to avoid any fallout (which I just did: https://dev.azure.com/dnceng/internal/_build/results?buildId=1023916&view=results) |
|
Hi @wtgodbe. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #30576