-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Handle more cases with the new entry point pattern #33500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
davidfowl
commented
Jun 13, 2021
- Handle an exception being thrown from main before start is called and make sure it propagates to the WebApplicationFactory.
- Don't hang if the application doesn't call Start before it completes.
- Handle an exception being thrown from main before start is called and make sure it propagates to the WebApplicationFactory. - Don't hang if the application doesn't call Start before it completes.
/azp run I just fixed this dotnet/runtime#54133 and this hang might be related. |
Command 'run
I' is not supported by Azure Pipelines.
See additional documentation. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@@ -1624,6 +1624,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhotinoTestApp", "src\Compo | |||
EndProject | |||
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNetCore.Components.WebView.Photino", "src\Components\WebView\Samples\PhotinoPlatform\src\Microsoft.AspNetCore.Components.WebView.Photino.csproj", "{B1AA24A4-5E02-4DC1-B57F-6EB03F91E4DD}" | |||
EndProject | |||
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SimpleWebSiteWithWebApplicationBuilderException", "src\Mvc\test\WebSites\SimpleWebSiteWithWebApplicationBuilderException\SimpleWebSiteWithWebApplicationBuilderException.csproj", "{5C641396-7E92-4F5C-A5A1-B4CDF480539B}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to create a new test project for each of these scenarios or is there a way for us to have one test project with multiple apps for each scenario (app runs fine, app throws exception, etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have a single app that changed behavior based on arguments.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This is still hanging, I need to look at the dump |
/backport to release/6.0-preview6 |
Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/941882086 |
This relates to dotnet/arcade#7532 but @epananth at least temporarily worked around that and got new dotnet/runtime versions into the '.NET 6' and '.NET 6 Preview 6' channels. You're waiting for #33560 in main and (for #33574) #33571 in release/6.0-preview6. Both are blocked by our need to react to dotnet/runtime#54147. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This reverts commit 2973167.
/backport to release/6.0-preview6 |
Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/949078033 |
/backport to release/6.0-preview6 |
Started backporting to release/6.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/949087635 |
* main: Handle more cases with the new entry point pattern (dotnet#33500) [main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet#33560) Refactor LongPolling in Java to avoid stackoverflow (dotnet#33564) Optimize QueryCollection (dotnet#32829) Switch to in-org action (dotnet#33610) Improve Codespaces + C# extension interaction (dotnet#33614)