[release/6.0-preview6] Handle more cases with the new entry point pattern #33633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ion being thrown from main before start is called and make sure it propagates to the WebApplicationFactory. - Don't hang if the application doesn't call Start before it completes.
This reverts commit 2973167.
github-actions
bot
requested review from
javiercn,
Pilchie and
pranavkm
as code owners
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #33500 to release/6.0-preview6
/cc @davidfowl
Customer Impact
This change fixes a couple of edge cases that would lead customers' unit tests to hanging when trying to use the new minimal hosting APIs with our existing testing framework (like if their application code threw an exception).
Testing
Unit tests (the scenario here enables). Unit testing similar to what code has been written in the change itself.
Risk
Low