-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/6.0-rc1] Add support for Results extension point #35574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
github-actions
wants to merge
6
commits into
release/6.0-rc1
from
backport/pr-35571-to-release/6.0-rc1
Closed
[release/6.0-rc1] Add support for Results extension point #35574
github-actions
wants to merge
6
commits into
release/6.0-rc1
from
backport/pr-35571-to-release/6.0-rc1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Damian Edwards <[email protected]> Co-authored-by: Stephen Halter <[email protected]>
4c5a85b
to
501f846
Compare
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
pranavkm
approved these changes
Aug 23, 2021
@captainsafia @pranavkm - this is included in #35632, right? |
Yep, it is. I'll close this out now since we're aggregating all the changes in one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Servicing-consider
Shiproom approval is required for the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35571 to release/6.0-rc1
/cc @captainsafia
Description/Customer Impact
This PR makes it easier for external libraries to extend the
Results
object used to returnIResult
objects from endpoints. This change improves discoverability for external library integrations with this API and provides a consistent implementation for external libraries to extend on.Regression?
Risk
Verification
Packaging changes reviewed?
Fixes #35508