Skip to content

[release/6.0-rc1] Add support for Results extension point #35574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 20, 2021

Backport of #35571 to release/6.0-rc1

/cc @captainsafia

Description/Customer Impact

This PR makes it easier for external libraries to extend the Results object used to return IResult objects from endpoints. This change improves discoverability for external library integrations with this API and provides a consistent implementation for external libraries to extend on.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low
  • Change was verified manually and via a new unit test.
  • Change exposes a set of extension properties that don't have have too much logic so low risk for bugs.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Fixes #35508

@captainsafia captainsafia force-pushed the backport/pr-35571-to-release/6.0-rc1 branch from 4c5a85b to 501f846 Compare August 22, 2021 21:27
@captainsafia captainsafia added the Servicing-consider Shiproom approval is required for the issue label Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@Pilchie
Copy link
Member

Pilchie commented Aug 24, 2021

@captainsafia @pranavkm - this is included in #35632, right?

@captainsafia
Copy link
Member

Yep, it is. I'll close this out now since we're aggregating all the changes in one.

@captainsafia captainsafia deleted the backport/pr-35571-to-release/6.0-rc1 branch August 25, 2021 22:25
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-consider Shiproom approval is required for the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants