Skip to content

Backport minimal action API changes to 6.0-rc1 #35632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

pranavkm
Copy link
Contributor

Description

As part of our feature review, we decided we wanted to avoid using the term minimal actions in code. The changes in this PR appear as part of types containing extension methods, and method parameter names, i.e. not high user impact, but we'd like to clean it up before 6.0 ships.

In addition, based on preview 7 user feedback, we're adding an API for 3rd party libraries to register an extensibility to minimal actions. The feature request came in late as libraries have only recently started experimenting with minimal actions.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

We have tests for these changes and no packaging changes are involved.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@davidfowl
Copy link
Member

The auth change is failing.

@pranavkm pranavkm added the Servicing-approved Shiproom has approved the issue label Aug 24, 2021
@pranavkm
Copy link
Contributor Author

This PR is ready to be merged.

@Pilchie Pilchie merged commit 49eae20 into release/6.0-rc1 Aug 24, 2021
@Pilchie Pilchie deleted the prkrishn/backport branch August 24, 2021 17:10
@ghost ghost added this to the 6.0-rc1 milestone Aug 24, 2021
@Pilchie
Copy link
Member

Pilchie commented Aug 24, 2021

Done.

@Pilchie Pilchie added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants