Skip to content

Update to stable Roslyn versions (#37663) #37764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Update to stable Roslyn versions (#37663) #37764

merged 1 commit into from
Oct 22, 2021

Conversation

pranavkm
Copy link
Contributor

Fixes #36682

Port 6.0 change to main

@pranavkm pranavkm requested a review from dougbu as a code owner October 21, 2021 21:33
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 21, 2021
dougbu
dougbu approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm: npm versions are correct in this branch❔

@pranavkm
Copy link
Contributor Author

Hmm, not sure about npm versions. This was primarily about porting this 6.0 change that came in a couple days ago: #37663

@dougbu
Copy link
Contributor

dougbu commented Oct 21, 2021

Ignore my comment @pranavkm. Was reviewing Selenium changes in parallel 🤦

@pranavkm pranavkm merged commit cf5d3ce into dotnet:main Oct 22, 2021
@pranavkm pranavkm deleted the update-roslyn branch October 22, 2021 18:10
@ghost ghost added this to the 7.0-preview1 milestone Oct 22, 2021
pranavkm added a commit to pranavkm/aspnetcore that referenced this pull request Oct 25, 2021
@pranavkm
Revert "Update to stable Roslyn versions (dotnet#37663) (dotnet#37764)"
3bb57e1 
This reverts commit cf5d3ce.
pranavkm added a commit that referenced this pull request Oct 25, 2021
@pranavkm
Revert "Update to stable Roslyn versions (#37663) (#37764)" (#37817)
bee5eda 
This reverts commit cf5d3ce.
@TanayParikh TanayParikh mentioned this pull request Sep 19, 2022
Merged
TanayParikh added a commit that referenced this pull request Sep 23, 2022
@TanayParikh
[release/7.0] Update Roslyn Versions
2a3027f 
Using the roslyn versions provided by @jaredpar: #44072 (comment)

For: #39387

References:
- #28125
- #37764
- #44072
@TanayParikh TanayParikh mentioned this pull request Sep 23, 2022
Merged
10 tasks
mkArtakMSFT pushed a commit that referenced this pull request Sep 29, 2022
@TanayParikh
[release/7.0] Update Roslyn Versions (#44148)
ed649ac 
Using the roslyn versions provided by @jaredpar: #44072 (comment)

For: #39387

References:
- #28125
- #37764
- #44072
@TanayParikh TanayParikh mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.

Update the compiler version referenced by Microsoft.CodeAnalysis.Razor
2 participants
@pranavkm @dougbu