Revert "Update to stable Roslyn versions (#37663) (#37764)" #37817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf5d3ce.
ghost
added
the
area-infrastructure
JamesNK
approved these changes
Oct 25, 2021
|
@JamesNK if you don't mind abusing your admin powers, we could get this merged. The only test failure is from a random Socket test. |
|
There isn't a rush so lets try to get it in without clicking a red button 😋 |
|
Probably unrelated to this PR but might be worth examining https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-37817-merge-5b84f6f79dd34abfba/Sockets.BindTests--net7.0/2/dotnet_10963_20211025T192329_hangdump.dmp to see why the tests timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cf5d3ce.
Compiler version in the SDK is behind the runtime: dotnet/sdk#22069 (comment). We probably want to tackle this differently for the future, but rolling back is the easiest way to unblock the PR.