Allow runtime compilation to be configured via the hosting startup. #39381
Conversation
As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case for registration via the HostingStartup. This PR address this defect. Fixes dotnet#38465
ghost
added
the
area-mvc
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @pranavkm - as someone who is unfamiliar with the .NET dev process, but is affected by this issue - how will this fix be released? Is it going to be included in a patch to .NET 6, or will we have to wait until .NET 7 to see this fix? I've read through the linked issue, but the outcome isn't clear to me. Thanks! |
|
@isaacdontjelindellblp my hope is to backport this to a 6.0 release once it's accepted in to main. |
@pranavkm Fantastic - thanks much! |
|
@dotnet/aspnet-blazor-eng could I get a quick review on this? I'd like to consider this for a 6.0 patch. |
|
Thanks for pushing this through @pranavkm |
|
Hi @AndrewTriesToCode. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
…otnet#39381) As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case for registration via the HostingStartup. This PR address this defect. Fixes dotnet#38465
…otnet#39381) As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case for registration via the HostingStartup. This PR address this defect. Fixes dotnet#38465
…39381) (#39639) As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case for registration via the HostingStartup. This PR address this defect. Fixes #38465
As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken.
The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case
for registration via the HostingStartup. This PR address this defect.
Fixes #38465