Allow runtime compilation to be configured via the hosting startup. #39639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#39381) As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. The refactoring assumed AddRuntimeCompilation was always invoked after a call to AddRazorPages / AddControllersWithViews etc which is not the case for registration via the HostingStartup. This PR address this defect. Fixes dotnet#38465
ghost
added
the
area-mvc
|
Hi @pranavkm. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Porting #39381 to release/6.0 |
mkArtakMSFT
added
the
Servicing-consider
|
Hi @pranavkm. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
leecow
added
Servicing-approved
|
@dotnet/aspnet-build could we get this merged? |
|
@pranavkm this is approved for 6.0.3 and branches aren't open for that version yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of refactoring how Razor Pages are loaded, the ability to use runtime compilation via the hosting startup / env variable was broken. We had this feature enabled via a project template option. Because we removed the option in 6.0 in favor of hot reload, we lost coverage for it and had no end-to-end tests. This change restores support for this feature and adds better test coverage.
Fixes #38465
Customer Impact
Users are unable to use the hosting startup from the runtime compilation package.
Regression?
[If yes, specify the version the behavior has regressed from] 5.0
Risk
The changes are limited to when the runtime compilation is referenced and enabled via the hosting startup feature.
Verification
Packaging changes reviewed?