Skip to content

[Backport] Fix browser cookie tests to only run with HTTPS #39680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[Backport] Fix browser cookie tests to only run with HTTPS #39680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d6d36c
Fix browser cookie tests to only run with HTTPS (#39665)
BrennanConroy Jan 21, 2022
1956670
fixup
BrennanConroy Jan 21, 2022
17e9538
fixup
BrennanConroy Jan 21, 2022
951d549
Skip tests with expired cert
HaoK Jan 21, 2022
1d0e4f1
Fxiup
HaoK Jan 21, 2022
d6d38f6
Fixup
HaoK Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Security/Authentication/test/CertificateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ public async Task VerifyClientCertWithUntrustedRootAndTrustedChainEndsUpInForbid
Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode);
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/39669")]
public async Task VerifyValidClientCertWithTrustedChainAuthenticates()
{
using var host = await CreateHost(
Expand Down
8 changes: 0 additions & 8 deletions src/SignalR/clients/ts/FunctionalTests/EchoConnectionHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,13 @@
using System.Buffers;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Connections;
using Microsoft.AspNetCore.Http.Connections;

namespace FunctionalTests
{
public class EchoConnectionHandler : ConnectionHandler
{
public async override Task OnConnectedAsync(ConnectionContext connection)
{
var context = connection.GetHttpContext();
// The 'withCredentials' tests wont send a cookie for cross-site requests
if (!context.WebSockets.IsWebSocketRequest && !context.Request.Cookies.ContainsKey("testCookie"))
{
return;
}

while (true)
{
var result = await connection.Transport.Input.ReadAsync();
Expand Down
4 changes: 2 additions & 2 deletions src/SignalR/clients/ts/FunctionalTests/ts/ConnectionTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,8 @@ describe("connection", () => {
withCredentials: false,
});

connection.onreceive = (data: any) => {
fail(new Error(`Unexpected messaged received '${data}'.`));
connection.onreceive = (_: any) => {
connection.stop();
};

// @ts-ignore: We don't use the error parameter intentionally.
Expand Down
Loading